Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for Dantel Webmon #9977

Merged
merged 7 commits into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Mar 16, 2019

Fixes #9972

This PR fixes the support of Dantel Webmon devices. Previous PR #9767 from @network-guy did assume a particular linecard set in a modular chassis, which is not correct.

The IDs of the sensors changed from the previous PR (only 20 days old, so not a lot of history lost anyway).

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@@ -227,7 +227,7 @@ function discover_sensor(&$valid, $class, $device, $oid, $index, $type, $descr,
$divisor = 1;
}
d_echo("Discover sensor: $oid, $index, $type, $descr, $poller_type, $divisor, $multiplier, $entPhysicalIndex, $current\n");
d_echo("Discover sensor: $oid, $index, $type, $descr, $poller_type, $divisor, $multiplier, $entPhysicalIndex, $current, (limits: LL: $low_limit, LW: $low_warn_limit, W: $warn_limit, H: $high_limit)\n");

This comment has been minimized.

Copy link
@PipoCanaja

PipoCanaja Mar 16, 2019

Author Contributor

I did add debugging on limits, this was missing. Please advise if you prefer them out of this PR.

This comment has been minimized.

Copy link
@murrant

murrant Mar 18, 2019

Member

No, I've always thought they were missing from the debug output ;)

@PipoCanaja PipoCanaja referenced this pull request Mar 16, 2019

Closed

Dantel Webmon LP Sensors #9972

3 of 3 tasks complete
@network-guy
Copy link
Contributor

left a comment

LGTM

@PipoCanaja PipoCanaja changed the title WIP - Dantel Webmon Improvement Dantel Webmon Improvement Mar 16, 2019

@PipoCanaja PipoCanaja added this to the 1.50 milestone Mar 16, 2019

@murrant murrant merged commit 70437ae into librenms:master Mar 18, 2019

5 of 6 checks passed

codeclimate 2 issues to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf changed the title Dantel Webmon Improvement Improved support for Dantel Webmon Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Dantel Webmon Improvement (librenms#9977)
* Generic polling for webmon

* Tests update

* clean

* tests and count sensor

* typo + tests

* update user friendly OS

* style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.