Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use $sensor[sensor_limit] if not available #9978

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
3 participants
@PipoCanaja
Copy link
Contributor

commented Mar 16, 2019

Following #9973, some graphs are using sensor_limit without checking if defined, which kills the RRD command.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja added the Bug 🐞 label Mar 16, 2019

@PipoCanaja PipoCanaja self-assigned this Mar 16, 2019

@amigne

amigne approved these changes Mar 16, 2019

@PipoCanaja PipoCanaja added this to the 1.50 milestone Mar 16, 2019

@TheGreatDoc
Copy link
Contributor

left a comment

LGTM

@TheGreatDoc TheGreatDoc merged commit 14b1929 into librenms:master Mar 17, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@PipoCanaja PipoCanaja deleted the PipoCanaja:graphs_limits branch Mar 17, 2019

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.