Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inconsistent <h3> closed by </div> #9982

Merged
merged 1 commit into from Mar 17, 2019

Conversation

Projects
None yet
3 participants
@amigne
Copy link
Contributor

commented Mar 17, 2019

Working on #9981, it was discovered an inconsistency in HTML tags : <h3> tag was closed by </div>.

This PR fixes this.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@amigne

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

Still WIP, as not yet tested.

@murrant
Copy link
Member

left a comment

LGTM. Browser was correcting the error before, but works correctly.

@murrant murrant changed the title WIP - Fix inconsistent <h3> closed by </div> Fix inconsistent <h3> closed by </div> Mar 17, 2019

@murrant murrant merged commit af2b405 into librenms:master Mar 17, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@amigne amigne deleted the amigne:fix-device-health-html-h3-closing branch Mar 17, 2019

@laf laf changed the title Fix inconsistent <h3> closed by </div> Fixed inconsistent <h3> closed by </div> Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.