Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TP-LINK T1600G-52TS #9983

Merged
merged 4 commits into from Apr 7, 2019

Conversation

Projects
None yet
4 participants
@spencerbutler
Copy link
Contributor

spencerbutler commented Mar 17, 2019

This fixes:
#9896

The MIBs (see below) from this vendor don't seem to add up for the T1600G-52TS model. The tpSysMonitorCpuTable Table is what we want to read from, but is not available. I'll see if I can coerce this device into sharing it's CPU and Memory details, but I don't have high hopes at the moment. The device is now detected as "TP-Link JetStream" with this commit.

T1600G-52TS MIBs
V1
V3

tpSysMonitorCpuTable

$ snmpwalk -v2c -c tplink-52ts -M mibs/tplink:mibs -m TPLINK-MIB:TPLINK-PRODUCTS-MIB:TPLINK-SYSMONITOR-MIB tplink-52ts:1161 tpSysMonitorCpuTable
TPLINK-SYSMONITOR-MIB::tpSysMonitorCpuTable = No more variables left in this MIB View (It is past the end of the MIB tree)

In V3 they also introduced some new OIDs into the TPLINK-PRODUCTS-MIB Module that are not defined anywhere (l2manageswitch and l3manageswitch), while this isn't germane to this issue, I wanted to mention it.

OIDs from the MIB to test

$ egrep '(tlsl5210_v1|tplink-t1600g-52ts)' mibs/tplink/TPLINK-PRODUCTS-MIB
tplink-t1600g-52ts OBJECT IDENTIFIER ::= { tplinkProducts 29 }
tlsl5210_v1 OBJECT IDENTIFIER ::= { l3manageswitch 65 }

vendor MIB

l3manageswitch

$ snmpwalk -v2c -c tplink-52ts -M mibs/tplink:mibs -m TPLINK-MIB:TPLINK-PRODUCTS-MIB:TPLINK-SYSMONITOR-MIB tplink-52ts:1161 l3manageswitch.65
Bad operator (_): At line 48 in mibs/tplink/TPLINK-PRODUCTS-MIB
l3manageswitch.65: Unknown Object Identifier (Sub-id not found: (top) -> l3manageswitch)

tplinkProducts

$ snmpwalk -v2c -c tplink-52ts -M mibs/tplink:mibs -m TPLINK-MIB:TPLINK-PRODUCTS-MIB:TPLINK-SYSMONITOR-MIB tplink-52ts:1161 tplinkProducts.29
Bad operator (_): At line 48 in mibs/tplink/TPLINK-PRODUCTS-MIB
TPLINK-MIB::tplinkProducts.29 = No more variables left in this MIB View (It is past the end of the MIB tree)

"commented bad OIDs" MIB

l3manageswitch

$ snmpwalk -v2c -c tplink-52ts -M mibs/tplink:mibs -m TPLINK-MIB:TPLINK-PRODUCTS-MIB:TPLINK-SYSMONITOR-MIB tplink-52ts:1161 l3manageswitch.65
l3manageswitch.65: Unknown Object Identifier (Sub-id not found: (top) -> l3manageswitch)

tplinkProducts

$ snmpwalk -v2c -c tplink-52ts -M mibs/tplink:mibs -m TPLINK-MIB:TPLINK-PRODUCTS-MIB:TPLINK-SYSMONITOR-MIB tplink-52ts:1161 tplinkProducts.29
TPLINK-PRODUCTS-MIB::tplink-t1600g-52ts = No more variables left in this MIB View (It is past the end of the MIB tree)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Mar 19, 2019

I don't think the comments in the yaml are needed. People can look here for extra info if needed. Please remove them.

Sigh, gotta love those totally broken mibs.

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

spencerbutler commented Mar 19, 2019

I don't think the comments in the yaml are needed. People can look here for extra info if needed. Please remove them.

Sigh, gotta love those totally broken mibs.

Yeah, I had no intention of leaving them there. They are more for personal notes while I work on the issue. I'll kill them the next time I checkout this branch.

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

spencerbutler commented Mar 24, 2019

I don't think the comments in the yaml are needed. People can look here for extra info if needed. Please remove them.

Sigh, gotta love those totally broken mibs.

commit d65859a kills these

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

spencerbutler commented Mar 24, 2019

Without working MIB files, there isn't much more I can do here. If you find working MIBs, please pass them on.

Referencing #9896

@spencerbutler spencerbutler force-pushed the spencerbutler:feature/lnms-9896 branch from d65859a to d3355e3 Apr 4, 2019

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

spencerbutler commented Apr 4, 2019

@SirMaple Can you give this a try and see if it works for you?

@spencerbutler spencerbutler changed the title WIP - Normalizing support for TP-Link Jetstream switches Added support for TP-LINK T1600G-52TS Apr 4, 2019

@murrant

murrant approved these changes Apr 4, 2019

@SirMaple

This comment has been minimized.

Copy link
Contributor

SirMaple commented Apr 4, 2019

@spencerbutler no change. Ran a manual discovery and poller after applying and still no CPU or Memory graphs for the T1600G-52TS.

@spencerbutler

This comment has been minimized.

Copy link
Contributor Author

spencerbutler commented Apr 4, 2019

@spencerbutler no change. Ran a manual discovery and poller after applying and still no CPU or Memory graphs for the T1600G-52TS.

What OS does it report as?

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

PipoCanaja commented Apr 4, 2019

@SirMaple Did you remove cache/os_defs.cache file before discovery ?

@SirMaple

This comment has been minimized.

Copy link
Contributor

SirMaple commented Apr 4, 2019

@spencerbutler I deleted the os_defs.cache as suggested by @PipoCanaja and it works!

OS reported is now "TP-Link JetStream" the same as the T1600G-28TS.

The 52TS is now also graphing CPU and RAM usage.

Thank you so much!

@murrant

murrant approved these changes Apr 7, 2019

@murrant murrant merged commit e1df2a3 into librenms:master Apr 7, 2019

2 checks passed

codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.