Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cisco temperature limit on discovery #9985

Merged
merged 3 commits into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@amigne
Copy link
Contributor

commented Mar 17, 2019

During discovery, some temperature sensors discovered on Cisco devices had their highest temperature value stored as warning high limit.

This patch fixes this behavior by storing this value as high limit, for new discovered devices.

The misc/notifications.rss is updated accordingly.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@amigne

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

Old behavior (threshold is reported as high warning limit):
image

New behavior (threshold is reported as high limit):
image

Embedded notifications.rss is updated as well:
image

@PipoCanaja

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

@murrant Can we merge this ? (don't have much experience with the notifications)

@murrant

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@murrant murrant merged commit bafc195 into librenms:master Mar 19, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@amigne amigne deleted the amigne:fix-cisco-temperature-limit branch Mar 20, 2019

@laf laf added the Bug 🐞 label Mar 31, 2019

@laf laf changed the title Fix cisco temperature limit Fixed cisco temperature limit on discovery Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix cisco temperature limit (librenms#9985)
* The SNMP value ciscoEnvMonTemperatureThreshold is now stored as high limit (and no more as high warning limit)

* Updating misc/notifications.rss to make the user aware of the behavioral change

* Addition of missing </description> in the misc/notifications.rss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.