Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nfdump stat support for NfSen #9987

Open
wants to merge 30 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@VVelox
Copy link
Contributor

VVelox commented Mar 18, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

You can now do fun stuff like find top talkers via nfdump. :3

@VVelox

This comment has been minimized.

Copy link
Contributor Author

VVelox commented Mar 18, 2019

image

Image of the new stat page for those curious. :)

@VVelox

This comment has been minimized.

Copy link
Contributor Author

VVelox commented Mar 18, 2019

To tired to deal with it now, but I will start with cleaning up the style stuff tomorrow night.

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Mar 18, 2019

@VVelox no rush. You should check the Scrutnizer output too, it has a few items that should be cleaned up.

@VVelox

This comment has been minimized.

Copy link
Contributor Author

VVelox commented Mar 19, 2019

@murrant All good. The codeclimate stuff is just it being crazy about a handful of non-issues.

VVelox added some commits Mar 21, 2019

@VVelox

This comment has been minimized.

Copy link
Contributor Author

VVelox commented Apr 8, 2019

@murrant Resolved and merged... it is all now good. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.