Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mysql table engine validation #9989

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
1 participant
@murrant
Copy link
Member

commented Mar 18, 2019

It would never show because the schema was checked first and it would always be wrong if the table engine was myisam.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fix mysql table engine validation
It would never show because the schema was checked first and it would always be wrong if the table engine was myisam.

@murrant murrant added the Bug 🐞 label Mar 18, 2019

@murrant murrant merged commit 1111f0a into librenms:master Mar 19, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-engine-validation branch Mar 19, 2019

@laf laf changed the title Fix mysql table engine validation Fixed mysql table engine validation Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Fix mysql table engine validation (librenms#9989)
It would never show because the schema was checked first and it would always be wrong if the table engine was myisam.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.