New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hardware and mysql version number for stats #999

Merged
merged 2 commits into from May 14, 2015

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented May 13, 2015

As per #997 + including mysql version number.

@laf laf added the Enhancement label May 13, 2015

@paulgear

This comment has been minimized.

Show comment
Hide comment
@paulgear

paulgear May 13, 2015

Member

Do PHP hashes work with a trailing comma on the last element? If we do that and put the closing bracket on a separate line, it will make for cleaner diffs in future.

Member

paulgear commented May 13, 2015

Do PHP hashes work with a trailing comma on the last element? If we do that and put the closing bracket on a separate line, it will make for cleaner diffs in future.

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 14, 2015

Member

Unsure, I've seen places it does work and places it doesn't.

Tested, it does so I've pushed an update.

Member

laf commented May 14, 2015

Unsure, I've seen places it does work and places it doesn't.

Tested, it does so I've pushed an update.

f0o added a commit that referenced this pull request May 14, 2015

Merge pull request #999 from laf/issue-997
Added hardware and mysql version number for stats

@f0o f0o merged commit ca73a8f into librenms:master May 14, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment