Compatibility and Improved output #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetIP for speedtest.cambridgefibre.uk retuns * a body which is not empty when queried with empty parameters * Just a string with IP informaiton (no distance) The code will not stop in this case but will printout a debug message.
The JSON output is now a list of objects one per server. The CSV output has no empty rows.
|
The cambridge-fibre test seems to be based on a really old version of librespeed by the way |
Is it worth to integrate this then ? |
|
If it doesn't break anything, I don't see why not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ciscoski
Added compatibility for cambridge-fibre backend
eb8ed96
GetIP for speedtest.cambridgefibre.uk retuns
The code will not stop in this case but will printout a debug message.
@ciscoski
Improved format for JSON and CSV output for multiple server.
8345bac
The JSON output is now a list of objects one per server.
The CSV output has no empty rows.