Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata pipe support which is compatible with forked-daapd. #214

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@billsq
Copy link

commented May 7, 2018

Use argument --metadata-pipe [/srv/music/librespot.metadata] to enable metadata pipe.
Recommend to use arguments --linear-volume --mixer pipe to properly send the volume.

@billsq billsq referenced this pull request May 7, 2018

Open

Metadata #7

@billsq billsq force-pushed the billsq:master branch from 9180c72 to 6de2ac5 May 7, 2018

@sashahilton00

This comment has been minimized.

Copy link
Member

commented May 11, 2018

I'm hesitant to merge this, as we've entertained merging things like this in the past, but have usually stuck to keeping librespot as the core functionality for connecting to Spotify/creating a Connect device, particularly @plietar. This functionality would be better suited to the librespot daemon, though I appreciate that we haven't written that yet...

@plietar

This comment has been minimized.

Copy link
Contributor

commented May 11, 2018

Yep, this way outside the scope for librespot, especially given how specific it is to one tool.

As I've mentioned before, I'm all for adding APIs that allow pulling that kind of stuff out, but not doing the actual I/O or hardcoding a specific format.

@plietar plietar closed this May 11, 2018

@sashahilton00

This comment has been minimized.

Copy link
Member

commented May 11, 2018

@billsq I'll try and remember to notify you once the daemon is written, which would be the appropriate place for this.

@MartB

This comment has been minimized.

Copy link

commented May 26, 2018

@sashahilton00 drop a comment here when that happens, im interested in it.

@chimpy

This comment has been minimized.

Copy link

commented Mar 19, 2019

Such a shame this never happened. Providing proper metadata cleanly to forked-daapd would save time and mean the whole librespotd thing doesn't even need to happen because forked-daapd would cover it all anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.