New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make install_sw support #174

Closed
Commenter123 opened this Issue Feb 25, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@Commenter123

Commenter123 commented Feb 25, 2016

Yesterday nginx 1.9.12 was released.
In this commit they changed the make install command of custom openssl to make install_sw:
nginx/nginx@fef872a
This breaks compatibility with libressl.

Also see this bugreport which nginx guys closed: "wontfix"
https://trac.nginx.org/nginx/ticket/908

@busterb

This comment has been minimized.

Member

busterb commented Mar 1, 2016

We already met nginx half-way with the 'config' script. It should be possible to add another phony target to Makefile.am to simulate install_sw. Given that it takes all of 5 seconds to do a full install with libressl (since it doesn't have to compile any .pod files), i'm not sure the extra effort to avoid manpages is worth it.

Try this patch:

diff --git a/Makefile.am b/Makefile.am
index 0804984..d92f347 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -6,3 +6,6 @@ pkgconfig_DATA = libcrypto.pc libssl.pc libtls.pc openssl.pc

 EXTRA_DIST = README.md README.windows VERSION config scripts
 EXTRA_DIST += CMakeLists.txt
+
+.PHONY: install_sw
+install_sw: install
@bob-beck

This comment has been minimized.

Member

bob-beck commented Mar 1, 2016

I am in full agreement with this approach :)

On Mon, Feb 29, 2016 at 05:20:18PM -0800, Brent Cook wrote:

We already met nginx half-way with the 'config' script. It should be possible to add another phony target to Makefile.am to simulate install_sw. Given that it takes all of 5 seconds to do a full install with libressl (since it doesn't have to compile any .pod files), i'm not sure the extra effort to avoid manpages is worth it.

Try this patch:

diff --git a/Makefile.am b/Makefile.am
index 0804984..d92f347 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -6,3 +6,6 @@ pkgconfig_DATA = libcrypto.pc libssl.pc libtls.pc openssl.pc

 EXTRA_DIST = README.md README.windows VERSION config scripts
 EXTRA_DIST += CMakeLists.txt
+
+.PHONY: install_sw
+install_sw: install

Reply to this email directly or view it on GitHub:
#174 (comment)

@Commenter123

This comment has been minimized.

Commenter123 commented Mar 1, 2016

Works fine. Please add this into master

@angristan

This comment has been minimized.

angristan commented Mar 12, 2016

Any update ?

@busterb

This comment has been minimized.

Member

busterb commented Mar 12, 2016

sure, fix is coming soon

@busterb busterb closed this in be3b129 Mar 12, 2016

@angristan

This comment has been minimized.

angristan commented Mar 12, 2016

Thanks :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment