-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(legacy): disable public radio page and redirect to login #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62b36ec
to
c3df211
Compare
I like this idea a lot. We regularly don't use the embedded site at all and LT is purely presenter/staff focused |
c3df211
to
3f07930
Compare
jooola
reviewed
Jan 22, 2024
jooola
reviewed
Jan 22, 2024
jooola
reviewed
Jan 22, 2024
jooola
reviewed
Jan 22, 2024
jooola
reviewed
Jan 22, 2024
legacy/application/views/scripts/form/preferences_general.phtml
Outdated
Show resolved
Hide resolved
jooola
requested changes
Jan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this is awesome, only a few nits.
fd80faf
to
4c99d13
Compare
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
Co-authored-by: Jonas L. <jooola@users.noreply.github.com>
1aee742
to
880e325
Compare
paddatrapper
approved these changes
Feb 1, 2024
LGTM. Please update the documentation to reflect this change |
jooola
reviewed
Feb 2, 2024
jooola
reviewed
Feb 2, 2024
jooola
approved these changes
Feb 2, 2024
Tested this locally, it rocks! |
jooola
added a commit
to mp3butcher/libretime
that referenced
this pull request
Feb 2, 2024
…ime#2903) ### Description Many people don't need the public page and use libretime purely for playout management. This adds the ability to have libretime publicly available but only present the login page to the user. **I have updated the documentation to reflect these changes**: no, but i will add documentation if this PR is accepted. ### Testing Notes **What I did:** Toggle the new ceckbox on the general settings, log out and back in and check behaviour. note: this may have conflicts with the trim overbooked PR since the toggle sits in the same place. If both are accepted this needs to be formatted nicely :-) --------- Co-authored-by: Thomas Göttgens <tgoettgens@mail.com> Co-authored-by: Jonas L. <jooola@users.noreply.github.com> Co-authored-by: Kyle Robbertze <paddatrapper@users.noreply.github.com> Co-authored-by: jo <ljonas@riseup.net>
jooola
added a commit
that referenced
this pull request
May 5, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](4.0.0...4.1.0) (2024-05-05) ### Features * **api:** implement file deletion ([#2960](#2960)) ([9757b1b](9757b1b)) * build schedule events exclusively in playout ([#2946](#2946)) ([40b4fc7](40b4fc7)) * **legacy:** add aac/opus support to dashboard player ([#2881](#2881)) ([95283ef](95283ef)) * **legacy:** disable public radio page and redirect to login ([#2903](#2903)) ([170d095](170d095)) * **legacy:** trim overbooked shows after autoloading a playlist ([#2897](#2897)) ([a95ce3d](a95ce3d)) * **legacy:** visual cue point editor ([#2947](#2947)) ([da02e74](da02e74)) * start celery worker programmatically ([#2988](#2988)) ([9c548b3](9c548b3)) ### Bug Fixes * **analyzer:** backslash non utf-8 data when probing replaygain ([#2931](#2931)) ([29f73e0](29f73e0)), closes [#2910](#2910) * apply replay gain preferences on scheduled files ([#2945](#2945)) ([35d0dec](35d0dec)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.49.1 ([#2899](#2899)) ([3e05748](3e05748)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.51.1 ([#2963](#2963)) ([22c303c](22c303c)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.53.1 ([#2972](#2972)) ([9192aaa](9192aaa)) * **deps:** update dependency gunicorn to v22 (security) ([#2993](#2993)) ([a2cf769](a2cf769)) * incorrect docker compose version ([#2975](#2975)) ([634e6e2](634e6e2)) * **installer:** setup the worker entrypoint ([#2996](#2996)) ([71b20ae](71b20ae)) * **legacy:** allow deleting file with api token ([#2995](#2995)) ([86da46e](86da46e)) * **legacy:** allow updating track types code ([#2955](#2955)) ([270aa08](270aa08)) * **legacy:** avoid crash when lot of streams in configuration ([#2915](#2915)) ([12dd477](12dd477)) * **legacy:** ensure validation is performed on the track type form ([#2985](#2985)) ([5ad69bf](5ad69bf)) * **legacy:** fix hidden fields in edit file form ([#2932](#2932)) ([f4b260f](f4b260f)) * **legacy:** replay_gain_modifier should be a system preference ([#2943](#2943)) ([37d1a76](37d1a76)) * remove obsolete docker compose version ([#2982](#2982)) ([fb0584b](fb0584b)) * trigger legacy tasks manager every 5m ([#2987](#2987)) ([7040d0e](7040d0e)) * **worker:** ensure celery beat is started ([#3007](#3007)) ([bfde17e](bfde17e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: jo <ljonas@riseup.net>
paddatrapper
pushed a commit
to libretime/website
that referenced
this pull request
May 5, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](libretime/libretime@4.0.0...4.1.0) (2024-05-05) ### Features * **api:** implement file deletion ([#2960](libretime/libretime#2960)) ([9757b1b](libretime/libretime@9757b1b)) * build schedule events exclusively in playout ([#2946](libretime/libretime#2946)) ([40b4fc7](libretime/libretime@40b4fc7)) * **legacy:** add aac/opus support to dashboard player ([#2881](libretime/libretime#2881)) ([95283ef](libretime/libretime@95283ef)) * **legacy:** disable public radio page and redirect to login ([#2903](libretime/libretime#2903)) ([170d095](libretime/libretime@170d095)) * **legacy:** trim overbooked shows after autoloading a playlist ([#2897](libretime/libretime#2897)) ([a95ce3d](libretime/libretime@a95ce3d)) * **legacy:** visual cue point editor ([#2947](libretime/libretime#2947)) ([da02e74](libretime/libretime@da02e74)) * start celery worker programmatically ([#2988](libretime/libretime#2988)) ([9c548b3](libretime/libretime@9c548b3)) ### Bug Fixes * **analyzer:** backslash non utf-8 data when probing replaygain ([#2931](libretime/libretime#2931)) ([29f73e0](libretime/libretime@29f73e0)), closes [#2910](libretime/libretime#2910) * apply replay gain preferences on scheduled files ([#2945](libretime/libretime#2945)) ([35d0dec](libretime/libretime@35d0dec)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.49.1 ([#2899](libretime/libretime#2899)) ([3e05748](libretime/libretime@3e05748)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.51.1 ([#2963](libretime/libretime#2963)) ([22c303c](libretime/libretime@22c303c)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.53.1 ([#2972](libretime/libretime#2972)) ([9192aaa](libretime/libretime@9192aaa)) * **deps:** update dependency gunicorn to v22 (security) ([#2993](libretime/libretime#2993)) ([a2cf769](libretime/libretime@a2cf769)) * incorrect docker compose version ([#2975](libretime/libretime#2975)) ([634e6e2](libretime/libretime@634e6e2)) * **installer:** setup the worker entrypoint ([#2996](libretime/libretime#2996)) ([71b20ae](libretime/libretime@71b20ae)) * **legacy:** allow deleting file with api token ([#2995](libretime/libretime#2995)) ([86da46e](libretime/libretime@86da46e)) * **legacy:** allow updating track types code ([#2955](libretime/libretime#2955)) ([270aa08](libretime/libretime@270aa08)) * **legacy:** avoid crash when lot of streams in configuration ([#2915](libretime/libretime#2915)) ([12dd477](libretime/libretime@12dd477)) * **legacy:** ensure validation is performed on the track type form ([#2985](libretime/libretime#2985)) ([5ad69bf](libretime/libretime@5ad69bf)) * **legacy:** fix hidden fields in edit file form ([#2932](libretime/libretime#2932)) ([f4b260f](libretime/libretime@f4b260f)) * **legacy:** replay_gain_modifier should be a system preference ([#2943](libretime/libretime#2943)) ([37d1a76](libretime/libretime@37d1a76)) * remove obsolete docker compose version ([#2982](libretime/libretime#2982)) ([fb0584b](libretime/libretime@fb0584b)) * trigger legacy tasks manager every 5m ([#2987](libretime/libretime#2987)) ([7040d0e](libretime/libretime@7040d0e)) * **worker:** ensure celery beat is started ([#3007](libretime/libretime#3007)) ([bfde17e](libretime/libretime@bfde17e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: jo <ljonas@riseup.net> libretime/libretime@1a985a4
paddatrapper
pushed a commit
to libretime/website
that referenced
this pull request
May 5, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](libretime/libretime@4.0.0...4.1.0) (2024-05-05) ### Features * **api:** implement file deletion ([#2960](libretime/libretime#2960)) ([9757b1b](libretime/libretime@9757b1b)) * build schedule events exclusively in playout ([#2946](libretime/libretime#2946)) ([40b4fc7](libretime/libretime@40b4fc7)) * **legacy:** add aac/opus support to dashboard player ([#2881](libretime/libretime#2881)) ([95283ef](libretime/libretime@95283ef)) * **legacy:** disable public radio page and redirect to login ([#2903](libretime/libretime#2903)) ([170d095](libretime/libretime@170d095)) * **legacy:** trim overbooked shows after autoloading a playlist ([#2897](libretime/libretime#2897)) ([a95ce3d](libretime/libretime@a95ce3d)) * **legacy:** visual cue point editor ([#2947](libretime/libretime#2947)) ([da02e74](libretime/libretime@da02e74)) * start celery worker programmatically ([#2988](libretime/libretime#2988)) ([9c548b3](libretime/libretime@9c548b3)) ### Bug Fixes * **analyzer:** backslash non utf-8 data when probing replaygain ([#2931](libretime/libretime#2931)) ([29f73e0](libretime/libretime@29f73e0)), closes [#2910](libretime/libretime#2910) * apply replay gain preferences on scheduled files ([#2945](libretime/libretime#2945)) ([35d0dec](libretime/libretime@35d0dec)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.49.1 ([#2899](libretime/libretime#2899)) ([3e05748](libretime/libretime@3e05748)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.51.1 ([#2963](libretime/libretime#2963)) ([22c303c](libretime/libretime@22c303c)) * **deps:** update dependency friendsofphp/php-cs-fixer to <3.53.1 ([#2972](libretime/libretime#2972)) ([9192aaa](libretime/libretime@9192aaa)) * **deps:** update dependency gunicorn to v22 (security) ([#2993](libretime/libretime#2993)) ([a2cf769](libretime/libretime@a2cf769)) * incorrect docker compose version ([#2975](libretime/libretime#2975)) ([634e6e2](libretime/libretime@634e6e2)) * **installer:** setup the worker entrypoint ([#2996](libretime/libretime#2996)) ([71b20ae](libretime/libretime@71b20ae)) * **legacy:** allow deleting file with api token ([#2995](libretime/libretime#2995)) ([86da46e](libretime/libretime@86da46e)) * **legacy:** allow updating track types code ([#2955](libretime/libretime#2955)) ([270aa08](libretime/libretime@270aa08)) * **legacy:** avoid crash when lot of streams in configuration ([#2915](libretime/libretime#2915)) ([12dd477](libretime/libretime@12dd477)) * **legacy:** ensure validation is performed on the track type form ([#2985](libretime/libretime#2985)) ([5ad69bf](libretime/libretime@5ad69bf)) * **legacy:** fix hidden fields in edit file form ([#2932](libretime/libretime#2932)) ([f4b260f](libretime/libretime@f4b260f)) * **legacy:** replay_gain_modifier should be a system preference ([#2943](libretime/libretime#2943)) ([37d1a76](libretime/libretime@37d1a76)) * remove obsolete docker compose version ([#2982](libretime/libretime#2982)) ([fb0584b](libretime/libretime@fb0584b)) * trigger legacy tasks manager every 5m ([#2987](libretime/libretime#2987)) ([7040d0e](libretime/libretime@7040d0e)) * **worker:** ensure celery beat is started ([#3007](libretime/libretime#3007)) ([bfde17e](libretime/libretime@bfde17e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: jo <ljonas@riseup.net> libretime/libretime@1a985a4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many people don't need the public page and use libretime purely for playout management. This adds the ability to have libretime publicly available but only present the login page to the user.
I have updated the documentation to reflect these changes:
no, but i will add documentation if this PR is accepted.
Testing Notes
What I did:
Toggle the new ceckbox on the general settings, log out and back in and check behaviour.
note: this may have conflicts with the trim overbooked PR since the toggle sits in the same place. If both are accepted this needs to be formatted nicely :-)