Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some reason the database is showing some wrong values here #3720

Closed
i30817 opened this issue Oct 3, 2016 · 6 comments
Closed

For some reason the database is showing some wrong values here #3720

i30817 opened this issue Oct 3, 2016 · 6 comments

Comments

@i30817
Copy link
Contributor

@i30817 i30817 commented Oct 3, 2016

ps1 thousand arms cd 1 (USA) SLUS-00845 is showing up as with name: "Thousand Arms (Japan) (Disc 2) after scanning its directory.

snes Clock Tower (Japan) is outright missing after snes directory 'scan directory'. The rom is not hardpatched and loads (softpatching with the aeon genesis ips file) if loaded from 'Load Content -> Select File and Detect core' instead.

These are the ones i noticed, no doubt there are more.

A question if you will, are you forbidding hardpatch romhacks and patched images from showing in the playlists after 'scan directory'? It doesn't seem so, since my own shows 'Brigantine - Grand Edition' which is a hardpatch. (even if mednafen crashes right away now that i tried it with 'CDIF_ReadSector() invalid sector type at LBA=22' lol).

Also Sega Mega CD are not showing at all.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ghost
Copy link

@ghost ghost commented Oct 3, 2016

That title indeed has the wrong serial in the database, the dat file here confirms that: https://github.com/libretro/libretro-database/blob/master/dat/Sony%20-%20PlayStation.dat

Currently for PS1 titles as long as the serial matches, then it should scan without issues.

I made a quick script to check this dat for titles with serials belonging to the wrong region, and here is what it found:

Thousand Arms (Japan) (Disc 2) = SLUS-00845
NBA in the Zone '98 (USA) = SLES-00171
Goal Storm '97 (USA) = SLES-00069
Thousand Arms (USA) (Disc 1) = SLPS-01781

@RobLoach
Copy link
Member

@RobLoach RobLoach commented Oct 3, 2016

The Serial matching vs CRCs could likely be a cause as well. Likely a candidate as to why Mega CD doesn't scan.

@ofry
Copy link

@ofry ofry commented Oct 9, 2016

Many items from Sega Dreamcast romset has incorrect data.

Example:

C:\Users\ofry\Downloads\DC_games\90 Minutes - Sega Championship Football v1.009 (2001)(Sega)(PAL)(M5)[!].7z#90 Minutes - Sega Championship Football v1.009 (2001)(Sega)(PAL)(M5)[!].gdi
Treasure Strike (Japan)
DETECT
DETECT
468C1495|crc
Sega - Dreamcast.lpl

etc, etc, etc.

Link to full playlist: https://dl.dropboxusercontent.com/u/97349870/Sega%20-%20Dreamcast.lpl
(pal games only, some entries removed (because I don't know german, french, italian languages xD and I have these games in english language)

@orbea
Copy link
Contributor

@orbea orbea commented Dec 27, 2018

@i30817 and @ofry Can you please bring up any further database issues in the correct issue tracker so they might get fixed?

https://github.com/libretro/libretro-database/issues

Thanks!

@orbea orbea closed this Dec 27, 2018
@i30817
Copy link
Contributor Author

@i30817 i30817 commented Dec 27, 2018

This is a old issue that was fixed there, i had forgotten about it.

Though there is still a issue like it open there but that is because one game has a wrong serial from factory (duplicated, so they 'should' use iso label or something to distinguish, but they don't) and retroarch is using serials to identify instead of checksums (this has other issues like the issue i recently opened about duplicate info and hacks never being recognized).

the dreamcast serials being wrong was also corrected (it was because the gdi contents didn't differ because the TOSEC group was dumb about databases and decided to 'standardize' track names without salt), and it was fixed by checking the hashsum of the game track. Which is hilariously slower, but that's the price you pay when you inherit bad design and upstream refuses to fix.

@orbea
Copy link
Contributor

@orbea orbea commented Dec 27, 2018

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants