Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aspect ratio enum changes can cause existing configs/overrides to break #7536

Open
dankcushions opened this issue Nov 5, 2018 · 0 comments
Open
Labels

Comments

@dankcushions
Copy link
Contributor

@dankcushions dankcushions commented Nov 5, 2018

Regarding this commit: 8a63ace

by adding a new aspect ratio index to the middle of the enum, existing configs that included aspect_ratio_index of anything after the new addition are broken - ie, they point to the wrong aspect ratio.

this is a problem for general users, and also retroarch's own documentation. eg
https://github.com/libretro/RetroArch/blob/master/retroarch.cfg#L226
and a lot of user-generated 'documentation' online:
https://www.google.co.uk/search?rlz=1C1CHBF_en-GBGB702GB702&ei=5mvgW6LKDMzBgAax1quYBA&q=aspect_ratio_index+22

and for me personally, my scripts for retropie: https://github.com/dankcushions/crt-pi-configs
(i can update the scripts, but my configs already out 'in the wild' are now invalid)

suggestion:
instead of aspect_ratio_index, how about aspect_ratio, and instead accept a human-readable string like 4:3

if you want to be really smart, you could interpret this string as an aspect ratio dynamically in the code, although i would guess you would still need an enum to generate the options for the GUI.

this will still break existing configs, but at least it will only break them ONCE, rather than every time we add a new aspect ratio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.