Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo savestate/loadstate #3069

Merged
merged 8 commits into from Jun 4, 2016
Merged

Undo savestate/loadstate #3069

merged 8 commits into from Jun 4, 2016

Conversation

andres-asm
Copy link
Contributor

  • Undo Load state reverts the game state to the exact point before loading was triggered (creates a gamename.undo file)
  • Undo Load state loads the backup save state generated right before saving such a state

Only tested on windows

@inactive123 inactive123 merged commit 86b35c8 into libretro:master Jun 4, 2016
@rz5
Copy link
Contributor

rz5 commented Jun 4, 2016

Some observations:

  1. If no savestates exist in the savestate dir, both new Undo options will print about the same message in the OSD:
    " Failed to load state from "path/to/savestate/dir" "
    Ideally, 'Undo Load State' would print out e.g. "Nothing to undo".

  2. If we do the following operations: Save State > Save State > Undo Save State > Undo Load State
    The last operation will fail and the expectation is that, since 'Undo Save State' LOADS the file 'content_name.last', the last operation undoes THAT.

  3. Undo Load State relies on a file generically called content_name.undo. The specification of this operation is that it shouldn't rely on anything on disk, it's an option that makes sense per session but not across sessions.
    At least that's how Dolphin seems to do it.

@andres-asm
Copy link
Contributor Author

  1. ok
  2. I don't really understand
  3. I don't really care about what dolphin does, I don't feel like splitting the content save operation in two to make save states in memory

@Jakobud
Copy link

Jakobud commented Mar 25, 2018

Is this something documented somewhere? How do you use this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants