Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Palettes not working with certain line endings #207

Closed
kcin2001 opened this issue Oct 31, 2021 · 2 comments · Fixed by #208
Closed

Custom Palettes not working with certain line endings #207

kcin2001 opened this issue Oct 31, 2021 · 2 comments · Fixed by #208

Comments

@kcin2001
Copy link

kcin2001 commented Oct 31, 2021

custom palettes from standalone (at least those made on windows) will not work because the core does not support the .pal file having cr/lf line endings and instead wants lf line endings

example non working palette created from and working in standalone (remove .txt and () to use)
default (cr-lf).pal.txt

example working palette that is the same file only now with line endings converted using n++ (remove .txt and () to use)
default (lf).pal.txt

@Sanaki
Copy link

Sanaki commented Oct 31, 2021

Just confirmed this. Ran unix2dos on my default palette and the core choked on the carriage returns.

[libretro INFO] [Gambatte] Using custom palette: /home/ccrowley/.config/retroarch/system/palettes/default.pal
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 1 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 2 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 3 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 4 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 5 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 6 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 7 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 8 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 9 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 10 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 11 (color left as default)
[libretro WARN] [Gambatte] Unable to read palette color in /home/ccrowley/.config/retroarch/system/palettes/default.pal, line 12 (color left as default)

@jdgleaver
Copy link
Contributor

This should solve the problem: #208 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants