New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems since core updates / mame backports #227

Closed
joolswills opened this Issue Dec 5, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@joolswills
Contributor

joolswills commented Dec 5, 2017

There have been a fair few issues reported at the RetroPie site related to some of the recent changes to the core.

Since many of the changes seem to be untested, and technically can introduce new issues, I would like to suggest a new libretro core (or branch) is created for the hacks/backports and roll back this core to how it was before.

Then we can have the best of both worlds without the new regressions / compatibility issues.

In the meantime in RetroPie I have forked this repo and created a branch from around the 17th september, which I may switch to for RetroPie for now due to the issues reported.

@joolswills joolswills changed the title from problems since cofre updates / backports to problems since core updates / mame backports Dec 5, 2017

@Darknior

This comment has been minimized.

Show comment
Hide comment
@Darknior

Darknior Dec 5, 2017

If we can choose what MAME core we want to use in the ES-SETUP ... why not, it's a good idea.
But it is not important for the common users. Nobody is using MAME core from source, it take time to compile, users are using BINary version.
Only testers are trying the source version to try games and compatibility.
If you only make a build when all is done, like you do for ES, it will be enough.

Darknior commented Dec 5, 2017

If we can choose what MAME core we want to use in the ES-SETUP ... why not, it's a good idea.
But it is not important for the common users. Nobody is using MAME core from source, it take time to compile, users are using BINary version.
Only testers are trying the source version to try games and compatibility.
If you only make a build when all is done, like you do for ES, it will be enough.

@joolswills

This comment has been minimized.

Show comment
Hide comment
@joolswills

joolswills Dec 5, 2017

Contributor

In regards to retropie that is not true. Binaries are updated all the time and I cannot be expected to just know when things are "unstable" - master branch should not be used for experimental and untested changes imho. Also for many platforms retropie is source only. From X86 to ODroid c2/xu3/tinkerboard and RPI on ubuntu etc.

For EmulationStation we have a stable branch - which I specifically manage so that's not comparable.

Contributor

joolswills commented Dec 5, 2017

In regards to retropie that is not true. Binaries are updated all the time and I cannot be expected to just know when things are "unstable" - master branch should not be used for experimental and untested changes imho. Also for many platforms retropie is source only. From X86 to ODroid c2/xu3/tinkerboard and RPI on ubuntu etc.

For EmulationStation we have a stable branch - which I specifically manage so that's not comparable.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Dec 5, 2017

Can you link me to these "issues" as far as im aware there was one around Mortal Kombat
sound which is fixed now what were the others exactly.

ghost commented Dec 5, 2017

Can you link me to these "issues" as far as im aware there was one around Mortal Kombat
sound which is fixed now what were the others exactly.

@joolswills

This comment has been minimized.

Show comment
Hide comment
@joolswills

joolswills Dec 5, 2017

Contributor

A few mentioned the mortal kombat sound - That's fully working now ? good news.

one user also mentioned narc - https://retropie.org.uk/forum/topic/14872/mortal-kombat-new-sound-issues-mame2003

There was a thread about a performance issues which you did some code changes for - https://retropie.org.uk/forum/topic/14756/retroarch-1-6-9-update-slowing-emulations-down/5

Many issues have been mentioned in reverts yourself too - so obviously many of the changes have introduced problems/regressions. If all the problems are resolved then good, but I suspect there will be more issues, and I think it would be useful to have a plain mame2003 core and a modified one.

Contributor

joolswills commented Dec 5, 2017

A few mentioned the mortal kombat sound - That's fully working now ? good news.

one user also mentioned narc - https://retropie.org.uk/forum/topic/14872/mortal-kombat-new-sound-issues-mame2003

There was a thread about a performance issues which you did some code changes for - https://retropie.org.uk/forum/topic/14756/retroarch-1-6-9-update-slowing-emulations-down/5

Many issues have been mentioned in reverts yourself too - so obviously many of the changes have introduced problems/regressions. If all the problems are resolved then good, but I suspect there will be more issues, and I think it would be useful to have a plain mame2003 core and a modified one.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Dec 28, 2017

Right should this "issue" be closed now as it's been proven to have been user error rather
than my code changes which were to blame here.

ghost commented Dec 28, 2017

Right should this "issue" be closed now as it's been proven to have been user error rather
than my code changes which were to blame here.

@joolswills joolswills closed this Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment