Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Re-implement and improve "Dual Joysticks" #278

Closed
markwkidd opened this issue Jun 9, 2018 · 6 comments

Comments

@markwkidd
Copy link
Collaborator

markwkidd commented Jun 9, 2018

Bear in mind that the entire "Dual Joystick" feature is a workaround because the RetroArch frontend does not yet provide a way to map two real input devices to one RetroPad.

There is at least one improvement to what we have now which is straightforward to implement, which is only displaying the existing "Dual Joysticks" option -- and only apply it -- to games which had those controls.

If it doesn't seem like RetroArch is going to implement this into its remapper anytime soon, it Dual Joysticks should probably be re-implemented as a RetroPad subtype. But even if it stays a core option long term, it should be reimplemented "on the libretro side" of the input system. In other words Dual Joysticks should rewrite the input from two RetroPads to be one RetroPad before the input is sent to the MAME input system.

My current very clever approach remaps it automatically within MAME but that is no good for netplay consistency.

@markwkidd

This comment has been minimized.

Copy link
Collaborator Author

markwkidd commented Jun 16, 2018

There is at least one improvement to what we have now which is straightforward to implement, which is only displaying the existing "Dual Joysticks" option -- and only apply it -- to games which had those controls.

This objective is accomplished with #293

@Loggahead

This comment has been minimized.

Copy link

Loggahead commented Jun 24, 2018

I noticed that the Dual Joysticks option only shows up in the quick menu for games that use 2 joysticks but I noticed that when I enable that setting for a game like Robotron it appears to be applying it to all games even if they don't utilize 2 sticks for player 1.

For example, if I have this turned on in the menu for Robotron and quit out and then launch TMNT, player 2's joystick doesn't work for player 2. If I go back to Robotron, disable that feature, and then go back to TMNT, all works as normal again.

@grant2258

This comment has been minimized.

Copy link
Contributor

grant2258 commented Jul 3, 2018

that happened to me a while back with sf2 not checked on the latest source though.

I think the code is just showing the option for games it should be maybe and thats the correct behavior.

The problem with a system like this is that these options should be disabled if the flags dont match as well im sure mark will fix this. I think there should also be some checking on the OPT_RSTICK_BTNS and dual joysticks so both cant be on.

I dont use retroarch or retropie much anymore since changing my setup for my barcade but will try help with any code that thats none input related.

@markwkidd

This comment has been minimized.

Copy link
Collaborator Author

markwkidd commented Jul 3, 2018

@grant2258

This comment has been minimized.

Copy link
Contributor

grant2258 commented Jul 3, 2018

I'll double check it I'll need to slip the pi in in the barcade though will try after work.

@grant2258

This comment has been minimized.

Copy link
Contributor

grant2258 commented Jul 4, 2018

@Loggahead I tried with the mame2003+ I had installed and the problem was there.

I updated to the latest source and the problem is gone Mark has fix this other games work with dual joystick enabled now.

Mark also included my latest pull req that will take the little random box that appears when starting games.

There is some changes that happened lately which means you need to do a clean compile as well. Doing a git pull and compiling just the new source isint advised. Do a make clean first if your compiling manually. Let us know how you get on

@markwkidd markwkidd closed this Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.