New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rayman 2 - Missing bump-mapping #70

Closed
twinaphex opened this Issue Jun 28, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@twinaphex
Member

twinaphex commented Jun 28, 2018

image

This is how the ground texture is rendered right now.
Apparently, this texture is supposed to look far more detailed by way of bump mapping, like this -

image

There is another known game that uses bump-mapping as well. Shenmue 2 uses it for rendering certain coins.

Both OIT and non-OIT renderers are currently missing this.

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jun 28, 2018

I traced back the commit which added the 'fake' implementation for bump mapping -

reicast@d70617f

@flyinghead

This comment has been minimized.

Collaborator

flyinghead commented Jul 2, 2018

Here is a first implementation: flyinghead@69263ed
Hard to tell if it's right or not. It looks similar to screenshots and videos of Rayman I've looked up though.

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jul 2, 2018

Awesome! I will be back in about two hours and then I will immediately get on with backporting this. I will also give the master backports another try - I think I might have screwed up before there.

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jul 3, 2018

This is now implemented in both OIT and non OIT renderers.

@twinaphex twinaphex closed this Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment