New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bomberman Online - Glitching title screen #71

Closed
twinaphex opened this Issue Jun 28, 2018 · 18 comments

Comments

Projects
None yet
3 participants
@twinaphex
Member

twinaphex commented Jun 28, 2018

@flyinghead Could be more YUV corruption issues maybe - the title screen seems to be a looping FMV video that plays over and over. Certain parts of this video are rendered correctly, but at specific intervals it glitches out.

image

Glitches -

image

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jun 28, 2018

Happens with both Reicast OIT and non-OIT.

@flyinghead

This comment has been minimized.

Collaborator

flyinghead commented Jun 28, 2018

Yep, happens on my fork as well. Could be a DMA timing issue or some sync problem.

@rcaridade145

This comment has been minimized.

rcaridade145 commented Jun 28, 2018

@flyinghead @twinaphex Maybe the yuv dma is not being correctly terminated, or its detection if faulty. It uses the ch2-dma. If you look at the page 57 of that doc i've sent you.

@flyinghead

This comment has been minimized.

Collaborator

flyinghead commented Jun 29, 2018

Actually it's a bug I introduced myself... Sorry
See flyinghead@f18aa63

@rcaridade145

This comment has been minimized.

rcaridade145 commented Jun 29, 2018

Great job @flyinghead 🥇
Yesterday i compared spg from reicast master and libretro. There are some differences on CalculateSync but i'm not sure which one is more correct, or not being correct works best on reicast

@flyinghead

This comment has been minimized.

Collaborator

flyinghead commented Jun 29, 2018

Thanks!
There is still a remaining problem though: the first FMV video hangs at this point:
bomberman online usa rdc -180629-125310
It happens both in upstream and in the libretro OIT core.
The game doesn't hang and pressing start leads you to the title screen. After a while the first FMV video is played again, but doesn't hang this time...

@rcaridade145

This comment has been minimized.

rcaridade145 commented Jun 29, 2018

@flyinghead talking about a cliffhanger. 🤣 This with dynarec? Any difference with interpreter? If not it may be a DMA issue.

@flyinghead

This comment has been minimized.

Collaborator

flyinghead commented Jun 29, 2018

Same with generic recompiler

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jun 29, 2018

Some of the SPG changes I carried over from MAME. The only thing I happened to notice as a result was that I got better frame pacing in the core vs. before.

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jun 29, 2018

Anyway, awesome commit. I will be sure to backport soon.

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jun 29, 2018

Backported the PR. Seems to work fine now.

Weirdly enough though, the FMV intro doesn't hang for me at all.

Try to see if the EG hack is being applied to your copy of the game -

https://github.com/libretro/reicast-emulator/blob/master/core/rom_luts.h#L49

@flyinghead

This comment has been minimized.

Collaborator

flyinghead commented Jun 29, 2018

Indeed, it wasn't applied. And that fixes it. Thanks!

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jun 29, 2018

If you had to add another entry, let me know what line you had to add so i can add it to the list.

@flyinghead

This comment has been minimized.

Collaborator

flyinghead commented Jun 29, 2018

I'm running the USA release but it's been "renumbered": RDC-0117

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jun 29, 2018

Hmm sucks, from looking at it, it seems that this serial number corresponds to another game -

RDC-0117| The king of Fighters '96 Collection (NEO4ALL RC4)

Can we find some other heuristic to more accurately identify games by? Seems a lot of the GD-ROM rips were renumbered/mislabelled.

@flyinghead

This comment has been minimized.

Collaborator

flyinghead commented Jun 29, 2018

Well I confirm its id is RDC-0117 although it should be RDC-0120 according to a reference I found by googling...
Using the Software name would be fine in this case: "BOMBERMAN ONLINE"

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jun 29, 2018

OK, let me see if we can maybe catch both of them at the same time through a software name lookup instead.

@twinaphex

This comment has been minimized.

Member

twinaphex commented Jul 1, 2018

I will close this for now since the main issue is fixed. Reminder to self: I still need to add the heuristic for detecting both versions of Bomberman Online.

@twinaphex twinaphex closed this Jul 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment