Skip to content

Add executable bit to script #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add executable bit to script #334

wants to merge 1 commit into from

Conversation

tim77
Copy link

@tim77 tim77 commented Dec 3, 2019

To make some linters happier.

@tim77
Copy link
Author

tim77 commented Dec 13, 2022

Gently ping. Should be safe to merge.

@fpscan fpscan requested a review from RobLoach January 26, 2023 08:58
@RobLoach
Copy link
Member

This PR does a bit more: #444

@baxysquare
Copy link
Collaborator

@RobLoach do you think that #444 supersedes this PR? If not, I'll go ahead and merge. If so, I'll close and merge 444 instead.

@RobLoach
Copy link
Member

@RobLoach do you think that #444 supersedes this PR? If not, I'll go ahead and merge. If so, I'll close and merge 444 instead.

I'd vote to roll with #444 instead, yeah. It does what this issue does, and more.

@baxysquare
Copy link
Collaborator

Okay let's go ahead and close it and merge #444. @tim77 if you have any issues with this course of action, feel free to reply to this issue and we'll go from there.

@baxysquare baxysquare closed this Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobLoach RobLoach Awaiting requested review from RobLoach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tim77 @RobLoach @baxysquare