Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved edits to the README.md file #1479

Merged
merged 6 commits into from May 12, 2022
Merged

Improved edits to the README.md file #1479

merged 6 commits into from May 12, 2022

Conversation

cr2007
Copy link
Contributor

@cr2007 cr2007 commented May 7, 2022

Reference Issue

None

What does this implement/fix? Explain your changes.

This implementation improves the overall layout of the README file

  • Improves the Heading
  • Adds a link to the logo
  • Center-Aligns both the logo and heading
  • Improves the Index with sub-bullets as well for the user to go directly to the point they need.
  • Adds a Back to Top ↥ button (aligned to the right) to go back to the top when the user is at the bottom of the file

Any other comments?

Feel free to add any more changes to these commits as you please.

Regards,
@cr2007

cr2007 added 5 commits May 7, 2022 16:34
Shows all the content headings within the README file and links it to the location accordingly
As displayed in Line 99, the appropriate format has been mentioned for soundfile and audioread
Makes it easier for the user to go back up to the file when they are at the very bottom of the file
And a minor change to the heading by adding '#' to the heading
Finally, center-aligning the logo, heading
@bmcfee bmcfee added the documentation Issues relating to docstrings, examples, and documentation build label May 7, 2022
@bmcfee
Copy link
Member

bmcfee commented May 7, 2022

Thanks for this! Would you mind rolling back the alignment bits that use inlined HTML? I'd prefer to keep things strict markdown here as noted in #1473. The README pulls double-duty here as our splash page on the github repository, and the package description in pypi.

@cr2007
Copy link
Contributor Author

cr2007 commented May 8, 2022

Hey @bmcfee !

Sure, that can be possible
Although as you have written in #1473 , how does it render when it appears in the package description? in pypi?

As center-aligning the logo, header make it easier for them to read
and putting the Back To Top button aligned to the right make it much easier to catch the user's attention amidst the long text.

If you could maybe share a screenshot within this thread of how it looks like, it'd help get a better idea perhaps.

If it doesn't go well, I can change those HTML elements to a (similar) Markdown state.

Regards,
@cr2007

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@lostanlen
Copy link
Contributor

Please disregard my review. I hadn't considered the importance of handling PyPI README

@bmcfee
Copy link
Member

bmcfee commented May 8, 2022

Although as you have written in #1473 , how does it render when it appears in the package description? in pypi?

The short answer is that I don't know, and I'd prefer to not deploy a test package just to find out.

According to the official docs, github-flavored markdown is supported as the default markdown. While that does techinically allow for inlined HTML, I'd still prefer to avoid it.

@cr2007 cr2007 requested a review from lostanlen May 10, 2022 04:26
@cr2007
Copy link
Contributor Author

cr2007 commented May 10, 2022

Hi @bmcfee ,

I have done the necessary changes as you had asked in the next commit following your comment.

Let me know if there is anything else that is required.

Regards,
@cr2007

P.S. I do suggest having a look if inline HTML does work in the documentation as it can definitely widen the possibilities of how you can show your documentation out there

@bmcfee
Copy link
Member

bmcfee commented May 12, 2022

This looks fine to me. Thanks again.

@bmcfee bmcfee merged commit b5780f6 into librosa:main May 12, 2022
@bmcfee bmcfee added this to the 0.9.2 milestone May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues relating to docstrings, examples, and documentation build
Development

Successfully merging this pull request may close these issues.

None yet

3 participants