Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #524, added safety check for frequency bands in spectral_contrast #555

Merged
merged 1 commit into from Apr 13, 2017
Merged

fixed #524, added safety check for frequency bands in spectral_contrast #555

merged 1 commit into from Apr 13, 2017

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Apr 13, 2017 •
edited

This adds a safety check that none of the frequency bands in spectral_contrast lie entirely above nyquist.

It also adds a test case to cover #524.

This should be good to go, assuming tests pass.

This change is Reviewable

@bmcfee bmcfee added the bug Something doesn't work like it should label Apr 13, 2017
@bmcfee bmcfee added this to the 0.5.1 milestone Apr 13, 2017
@bmcfee bmcfee self-assigned this Apr 13, 2017
@bmcfee
Copy link
Member Author

bmcfee commented Apr 13, 2017

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee bmcfee merged commit eaf5e8f into master Apr 13, 2017
@bmcfee bmcfee deleted the scontrast-error branch April 13, 2017 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmcfee bmcfee

Labels
bug Something doesn't work like it should
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bmcfee