Skip to content

/ librsync

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`make test` doesn't build the tests #49

Closed
sourcefrog opened this issue Nov 25, 2015 · 1 comment
Closed

`make test` doesn't build the tests #49

sourcefrog opened this issue Nov 25, 2015 · 1 comment
Assignees
@sourcefrog
Labels
bug

Comments

@sourcefrog
Copy link
Contributor

@sourcefrog sourcefrog commented Nov 25, 2015

After merging the CMake patch from @Salamek (thanks), I see that make test doesn't implicitly build the tests. You have to make all first or they may fail.

I tried to get this working and could not. Maybe someone else can. For the moment I just added a note to README.md.
@sourcefrog sourcefrog added the bug label Nov 25, 2015
@sourcefrog
Copy link
Contributor Author

@sourcefrog sourcefrog commented Jan 10, 2016

Adding an explicit make check per https://cmake.org/Wiki/CMake/Testing_With_CTest#Simple_Testing seems like the best option.
@sourcefrog sourcefrog self-assigned this Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sourcefrog sourcefrog

Labels
bug
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@sourcefrog