Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid check_c_source_runs() when cross compiling #136

Merged
merged 1 commit into from Feb 4, 2018
Merged

Avoid check_c_source_runs() when cross compiling #136

merged 1 commit into from Feb 4, 2018

Conversation

fornwall
Copy link
Contributor

@fornwall fornwall commented Dec 23, 2017

Using check_c_source_runs() causes the build to fail when cross compiling. In that case we cannot check for printf "%zu" size_t formating support by executing a binary - instead assume it.

This should be safe as AFAIK only MS Visual Studio versions prior to VS2013 doesn't support it, and it's unlikely that someone should be using an old Visual Studio to cross compile librsync.

When cross compiling we cannot check for printf "%zu" size_t formating
support - instead assume it.
@dbaarda
Copy link
Member

@dbaarda dbaarda commented Feb 4, 2018

I'm not sure if there is a better way to do this than just assume it works for cross-compiling, but I'll accept it as better than what we currently have.

@dbaarda dbaarda merged commit 3eb640f into librsync:master Feb 4, 2018
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants