Fix memory leak on signature->block_sigs #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaarda
reviewed
Jun 8, 2018
There was a problem hiding this comment.
Wow, that's embarrassing, how did I miss that.
I think what happened is at one point the blocksums were an unsized array at the end of the rs_signature_t instead of a separate allocation, and thus didn't need it's own free.
This is a good catch, but your fix is slightly wrong... you need to do the free before the sig is zeroed, otherwise you are just freeing a null pointer, which is a no-op.
src/sumset.c
Outdated
| @@ -168,6 +168,8 @@ void rs_signature_done(rs_signature_t *sig) | |||
| { | |||
| hashtable_free(sig->hashtable); | |||
| rs_bzero(sig, sizeof(*sig)); | |||
|
|
|||
| free(sig->block_sigs); | |||
There was a problem hiding this comment.
You need to do this before the sig is zero'ed... so put it after hashtable_free() and before rs_bzero().
|
Done @dbaarda . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was a memory leak on rs_job_iter, after investigating I found that it was not freeing memory hold by
rs_signature_t->block_sigs.This patch fixed the memory leak.