disable HAVE_PRINTF_Z when directly compiling on Windows #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-arrange the logic to be a little less convoluted, and add comments explaining why it's done that way.
|
Thanks again for this. It's pretty strange. Are you sure that the HAVE_PRINTF_Z checks weren't being cached from an earlier (perhaps cross-compiled) cmake run? Try purging your git client and trying again with; $ git clean -fdx Assuming it wasn't as simple as that, I've done some tidyups and added comments, and I'll probably merge this soon. |
|
@dbaarda I am pretty sure HAVE_PRINTF_Z checks were not being cached from an earlier run. Did Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes warnings when directly compiling on Windows rather than just cross-compiling. The CheckCSourceRuns check for HAVE_PRINTF_Z somehow results in a success for HAVE_PRINTF_Z when directly configuring on Windows, resulting in multiple format warnings during compilation.