Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -1 for "unknown" for file sizes. #168

Merged
merged 2 commits into from Oct 2, 2019
Merged

Conversation

dbaarda
Copy link
Member

@dbaarda dbaarda commented Oct 2, 2019

Change rs_file_size() to return -1 for unknown file sizes and update docstring in librsync.h. In sumset.c update rs_signature_init() work correctly for sig_fsize<12.

Update sumset_test.c to use -1 for unknown filesizes and add some tests for checking invalid blake2 strong_len arguments.

dbaarda added 2 commits Oct 2, 2019
Change rs_file_size() to return -1 for unknown file sizes. in librsync.h
update docstring for rs_file_size() for this. In sumset.c update
rs_signature_init() work correctly for sig_fsize<12.

Update sumset_test.c to use -1 for unknown filesizes and add some tests for
checking invalid blake2 strong_len arguments.
@dbaarda
Copy link
Member Author

@dbaarda dbaarda commented Oct 2, 2019

This cherrypicks a change from #109 that is independent of that change, and really should have been like this from the start.

Because it's pretty trivial I'm going to merge it now.

@dbaarda dbaarda merged commit 5d94a10 into librsync:master Oct 2, 2019
1 check passed
@dbaarda dbaarda deleted the dev/filesize1 branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant