Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation with MS Visual Studio ad ignore build files #170

Merged
merged 1 commit into from Oct 2, 2019

Conversation

ardovm
Copy link
Contributor

@ardovm ardovm commented Oct 2, 2019

The Visual Studio C++ compiler seems not to like the current implementation of the _KEY_HASH macro. This pull request is aimed to restore compatibility with Microsoft Visual Studio 2019.

In addition, some wildcards are added to .gitignore targeting output files from CMake and from the build.

@dbaarda
Copy link
Member

@dbaarda dbaarda commented Oct 2, 2019

I did some digging and it seems "compound statement expressions" are a gcc extension that is not part of the c99 standard.

So this was my bad, and thanks for fixing it.

I'm going to merge now.

@dbaarda dbaarda merged commit ebc7f7a into librsync:master Oct 2, 2019
1 check passed
@ardovm
Copy link
Contributor Author

@ardovm ardovm commented Oct 2, 2019

That was quick! Thank you!

@ardovm ardovm deleted the vs2019 branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants