Skip to content
Permalink
Browse files

Date: Thu, 19 Jan 2006 20:02:29 +0200

From: Vassilis Virvilis <vasvir@iit.demokritos.gr>
Subject: [SDL] Request: Please reconsider adding tag in SDL_Event

Hi,

Patch in question:

--- include/SDL_events.h        20 Aug 2004 18:57:01 -0000      1.11
+++ include/SDL_events.h        19 Jan 2006 17:35:09 -0000
@@ -214,7 +214,7 @@
  } SDL_SysWMEvent;

  /* General event structure */
-typedef union {
+typedef union SDL_Event {
         Uint8 type;
         SDL_ActiveEvent active;
         SDL_KeyboardEvent key;

Reasoning:
----------
1) Allows forward declaration of the SDL_Event union in C++. Please
note that in plain C it is possible to forward declare it.

2) Forward declaration is good because it allows encapsulation. It hides
the specific implementation and does not necessarily exposes SDL staff
to my appication's namespace

3) It can't harm plain C because tags are living in a different namespace
than typenames

4) It is already done like this in other places in SDL. Check for example
SDL_KeySym, and SDL_.*Event structures.

5) Right now I have to include SDL/event.h from a C++ header file. See 2)
  • Loading branch information
slouken committed Jan 20, 2006
1 parent 1586fbd commit 7ead363e3681a53638856e296f75639f03030192
Showing with 1 addition and 1 deletion.
  1. +1 −1 include/SDL_events.h
@@ -214,7 +214,7 @@ typedef struct SDL_SysWMEvent {
} SDL_SysWMEvent;

/* General event structure */
typedef union {
typedef union SDL_Event {
Uint8 type;
SDL_ActiveEvent active;
SDL_KeyboardEvent key;

0 comments on commit 7ead363

Please sign in to comment.