Skip to content
Permalink
Browse files
Fixed typo in mask comparison
Bl0ckeduser

I downloaded the SDL 1.2.15 prerelease and compiled it (under Mac OS
Classic). All the tests worked without issues, but the compiler gave
this warning [formatting edited for email format]:

    } else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {

":src:video:SDL_video.c"; line 990 #Warning 2: possible unintended assignment

I discussed this with another programmer and we came to the conclusion
that this is probably a typo.

I have checked the latest mercurial sources, and the possible typo is
still there.

Bl0ckeduser
  • Loading branch information
slouken committed Jan 11, 2012
1 parent 726a10c commit ad3035543df19a3244803693a4980d515ed7d844
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/video/SDL_video.c
@@ -987,7 +987,7 @@ SDL_Surface *SDL_DisplayFormatAlpha(SDL_Surface *surface)
if ( (vf->Rmask == 0xff) && (vf->Bmask == 0xff0000) ) {
rmask = 0xff;
bmask = 0xff0000;
} else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {
} else if ( vf->Rmask == 0xFF00 && (vf->Bmask == 0xFF000000) ) {
amask = 0x000000FF;
rmask = 0x0000FF00;
gmask = 0x00FF0000;

0 comments on commit ad30355

Please sign in to comment.