Skip to content
Permalink
Browse files

Brian Fisher fixed bug #513

If an app requests a 24-bit opengl mode on a machine with a 32-bit desktop with
the windib video backend, then when exiting fullscreen the desktop resolution
is not restored

The reason this is, is because the windib backend restores the desktop
resolution when exiting fullscreen in DIB_SetVideoMode when it finds that the
last request was for fullscreen by checking the original flags on the video
surface. However, if the bits per pixel requested is different than current
surface, the video surface is recreated and the original video flags are lost.
So the check to see if we were exiting fullscreen fails.

below is a patch to SDL_dibvideo.c that solves the problem by using the
original flags in all cases.

thanks!
  • Loading branch information
slouken committed Dec 28, 2007
1 parent b45fab8 commit e5b3573cc88f198fd4638e60105fca982a8537e9
Showing with 2 additions and 1 deletion.
  1. +2 −1 src/video/windib/SDL_dibvideo.c
@@ -484,6 +484,8 @@ SDL_Surface *DIB_SetVideoMode(_THIS, SDL_Surface *current,
int x, y;
Uint32 Rmask, Gmask, Bmask;

prev_flags = current->flags;

/* Clean up any GL context that may be hanging around */
if ( current->flags & SDL_OPENGL ) {
WIN_GL_ShutDown(this);
@@ -531,7 +533,6 @@ SDL_Surface *DIB_SetVideoMode(_THIS, SDL_Surface *current,
}

/* Fill in part of the video surface */
prev_flags = video->flags;
prev_w = video->w;
prev_h = video->h;
video->flags = 0; /* Clear flags */

0 comments on commit e5b3573

Please sign in to comment.