Skip to content
Permalink
Browse files

Fixed bug #176

[I'm fixing this for the public headers, but I'm not going to bother for the SDL library code (yet)]

To clarify: Normaly, GCC (or, to be precise, the preprocessor) will ignore
this, and compile the code happily. However, one can specify -Wundef to get a
warning about this.

One can probably argue whether to consider this a bug or not; but I think that
(a) from a semantic point of view, using "#if FOO" when FOO is not defined is
strange, and (b) since it is possible to trigger a warning about this, and a
trivial fix exists, it should be corrected.

I can think of two alternative patches, BTW:
1) Simply use #define HAVE_FOO 0, instead of not defining HAVE_FOO at all
2) Change
  #if HAVE_FOO
to
  #if HAVE_FOO+0
which always does the right thing.

But I think I still prefer the attached patch :-).
  • Loading branch information
slouken committed Apr 13, 2006
1 parent 1b1edf4 commit eeaea166ee73ac4e5d825c0d1a5707f5e8b52b0b
Showing with 79 additions and 81 deletions.
  1. +1 −1 include/SDL_config_win32.h
  2. +73 −75 include/SDL_stdinc.h
  3. +5 −5 include/SDL_syswm.h
@@ -63,7 +63,7 @@ typedef unsigned int uintptr_t;

/* Enabled for SDL 1.2 (binary compatibility) */
#define HAVE_LIBC 1
#if HAVE_LIBC
#ifdef HAVE_LIBC
/* Useful headers */
#define HAVE_STDIO_H 1
#define STDC_HEADERS 1

0 comments on commit eeaea16

Please sign in to comment.