Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL has no way to control screensaver. #291

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

SDL has no way to control screensaver. #291

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Labels
enhancement

Comments

@SDLBugzilla
Copy link
Collaborator

@SDLBugzilla SDLBugzilla commented Feb 10, 2021

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: 1.2.11
Reported for operating system, platform: All, All

Comments on the original bug report:

On 2007-03-14 19:36:49 +0000, Ryan C. Gordon wrote:

On X11 and others, SDL explicitly disables the screensaver while the videomode is set, even in a window. For most games, this is desirable, but for things like TuxPaint, it would be nice to have a way to instruct SDL to leave the platform's screensaver alone.

For 1.2, I think an environment variable will suffice:

SDL_ALLOWSCREENSAVER=1

For 1.3, a formal API might be better.

--ryan.

On 2007-03-14 20:12:39 +0000, Ryan C. Gordon wrote:

Created attachment 198
Patch to disable screensaver on Mac OS X and X11.

This patch uses SDL_ALLOWSCREENSAVER on Mac OS X and X11 targets, for the 1.2 branch.

--ryan.

On 2007-04-06 13:28:18 +0000, Ryan C. Gordon wrote:

Created attachment 204
Updated patch with cleanups.

Updated patch that only checks the environment variable on X11 at VideoInit time...so behaviour is correct even if environment table changes during execution.

--ryan.

On 2007-04-06 13:31:18 +0000, Ryan C. Gordon wrote:

Fixed in svn revision # 3015.

--ryan.

On 2007-06-14 22:57:56 +0000, Ryan C. Gordon wrote:

Reopening bug and setting to P1; would like to get Windows in here for 1.2.12.

--ryan.

On 2007-06-14 23:00:30 +0000, Ryan C. Gordon wrote:

Created attachment 212
windib screensaver allowance patch

Here's a patch to the windib target to allow the screensaver in the same way as Mac OS X and X11...I don't think we can safely do this for the DX5 target, since it mentions losing the screen surface upon the screensaver starting...I'm okay with that, though.

This patch is untested, I don't have a Windows box handy.

--ryan.

On 2007-06-14 23:01:31 +0000, Ryan C. Gordon wrote:

Tossing bug to Sam...can you make sure that Attachment # 212 actually compiles on Windows?

Thanks,
--ryan.

On 2007-06-26 13:04:47 +0000, Ryan C. Gordon wrote:

Tested on windib, and it works, so I committed it. Fixed in svn revision # 3105.

This doesn't apply to 1.3, which should formalize this in an API and not an environment variable.

--ryan.

@SDLBugzilla SDLBugzilla added the enhancement label Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

No branches or pull requests

1 participant