Skip to content

[PATCH] Please update PulseAudio driver #396

@SDLBugzilla

Description

@SDLBugzilla

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 1.2.13
Reported for operating system, platform: Linux, x86

Comments on the original bug report:

On 2008-03-31 12:38:00 +0000, Lennart Poettering wrote:

Please merge this patch for the PA driver in SDL.

http://0pointer.de/public/sdl-pulse-rework.patch

This patch:

  • fixes buffering (i.e. reduces number of "fragments" to 2, doesn't defer
    filling up of the buffer until the entire buffer ran completely empty.)
  • drops $PASERVER and $PADEVICE env var support, since this is a duplication of
    $PULSE_SERVER and $PULSE_SINK which the PA libs honor anyway.

This fixes the sound issues in all games I tested.

On 2008-04-08 10:56:36 +0000, Ryan C. Gordon wrote:

This patch removes the setting of paattr.fragsize ... should we not have set that?

(If nothing else, we're not memset()'ing this struct, so it's going to be uninitialized data if we don't set it explicitly...)

--ryan.

On 2008-05-05 16:02:42 +0000, Lennart Poettering wrote:

The fragsize is only relevant for recording. It's irrelevant for playback. It's safe to leave it uninitialized.

On 2008-07-18 23:52:56 +0000, Jeremy Visser wrote:

*** Bug 557 has been marked as a duplicate of this bug. ***

On 2009-01-16 07:27:22 +0000, Sven Arvidsson wrote:

At least a couple of games still have problems with cracks in the audio, Frozen-Bubble and X-moto.

In both cases it's enough to just listen to the music playing in the menu. There are no such problems if SDL_AUDIODRIVER is set to esd or alsa.

In the downstream Mandriva bug, it's suggested to use mixlen*3 or *4, at the cost of higher latency.

On 2009-09-13 16:33:37 +0000, Ryan C. Gordon wrote:

Tagging this bug with "target-1.2.14" so we can try to resolve it for SDL 1.2.14.

Please note that we may choose to resolve it as WONTFIX. This tag is largely so we have a comprehensive wishlist of bugs to examine for 1.2.14 (and so we can close bugs that we'll never fix, rather than have them live forever in Bugzilla).

--ryan.

On 2009-09-21 01:04:55 +0000, Sam Lantinga wrote:

Thanks, this has been added to subversion for SDL 1.2. Do you have a similar patch for SDL 1.3? (http://www.libsdl.org/trunk/SDL)

On 2009-09-21 02:10:35 +0000, Ozkan Sezer wrote:

This is, kind of, a duplicate of bug # 698 which has an updated patch. An old outdated version just went into SDL-1.2.

On 2009-09-21 05:11:06 +0000, Sam Lantinga wrote:

Yeah, I noticed that. The new good stuff is in subversion now. Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions