windib sets SDL_HWPALETTE for >8 bit video modes; segfaults in SetGammaRamp

[SDLBugzilla]

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

• dib-hwpalette-fix.patch (dib-hwpalette-fix.patch, text/plain, 2008-09-04 17:56:47 +0000, 462 bytes)

Reported in version: 1.2.13
Reported for operating system, platform: Windows (All), x86

Comments on the original bug report:

On 2008-09-04 17:55:41 +0000, Gregory Smith wrote:

windib appears to always set the SDL_HWPALETTE flag in SetVideoMode, even when the bit depth is greater than 8. This can cause a segfault when SetGammaRamp is called, as it blindly tries to dereference the non-existent palette's colors.

I think the line video->flags |= SDL_HWPALETTE should be inside the scope of the preceeding if statement, as in the attached patch.

On 2008-09-04 17:56:47 +0000, Gregory Smith wrote:

Created attachment 272
dib-hwpalette-fix.patch

I think this will fix the bug

On 2009-09-13 16:33:29 +0000, Ryan C. Gordon wrote:

Tagging this bug with "target-1.2.14" so we can try to resolve it for SDL 1.2.14.

Please note that we may choose to resolve it as WONTFIX. This tag is largely so we have a comprehensive wishlist of bugs to examine for 1.2.14 (and so we can close bugs that we'll never fix, rather than have them live forever in Bugzilla).

--ryan.

On 2009-09-26 22:40:05 +0000, Sam Lantinga wrote:

This is already fixed in subversion. Thanks!