Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

Daniel Wyatt 2010-03-26 14:52:53 PDT

If a non-console Windows SDL program has a non-quoted 0th argument followed
optionally by more non-quoted arguments and then by an empty quoted argument,
it will crash (attempts to dereference a NULL pointer).

In other words, something like this:
test.exe [non-quoted args] "" [...]

The fix is a one-liner in ParseCommandLine() of
src/main/win32/SDL_win32_main.c.

You can test this with any non-console SDL program on windows like this:
1) Open a console (cmd.exe)
2) Launch the program in one of the following ways:
program ""
program arg1 ""
program arg1 "" arg3

These will not cause a crash:
"program" [...]
program "arg1" ""

When a Windows program is launched from Explorer, its 0th argument seems to
always be quoted, so it won't be a problem in that case.

I've tested this on Windows XP SP3 and Windows 7.
  • Loading branch information
slouken committed Jul 13, 2010
1 parent 111d7b4 commit 059f51b8bdc35ba5a85ea53eab273bdd9a6181c9
Showing with 1 addition and 0 deletions.
  1. +1 −0 src/main/win32/SDL_win32_main.c
@@ -71,6 +71,7 @@ ParseCommandLine(char *cmdline, char **argv)
++argc;
}
/* Skip over word */
lastp = bufp;
while (*bufp && (*bufp != '"' || *lastp == '\\')) {
lastp = bufp;
++bufp;

0 comments on commit 059f51b

Please sign in to comment.