Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files
Fixed bug 1923 - Crash with SDL_SetColorKey
Sylvain

1/ Load an Image XPM with IMG_ReadXPMFromArray()
2/ Try to set a ColorKey on it.

I notice that :
- the SDL_Surface that is created from XPM has a palette !
- the colorkey is a RBG.

it crashes (SIGSEGV) inside the SDL_SetColorKey function:
"surface->format->palette->colors[surface->map->info.colorkey].a"
  • Loading branch information
slouken committed Jul 7, 2013
1 parent 729c67e commit 1a65483a219dccec92d7ac3efcb62bbd4ac0a1dd
Showing with 5 additions and 1 deletion.
  1. +5 −1 src/video/SDL_surface.c
@@ -175,7 +175,11 @@ SDL_SetColorKey(SDL_Surface * surface, int flag, Uint32 key)
int flags;

if (!surface) {
return -1;
return SDL_InvalidParamError("surface");
}

if (surface->format->palette && key >= surface->format->palette->ncolors) {
return SDL_InvalidParamError("key");
}

if (flag & SDL_RLEACCEL) {

0 comments on commit 1a65483

Please sign in to comment.