Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

Allocate SDL_AudioCVT::coeff before using it.

FIXME: this is a memory leak. We don't have an SDL_FreeAudioCVT() yet.
  • Loading branch information
icculus committed Dec 19, 2008
1 parent d191fb3 commit 81c4db00737f51ddb743d28464533ef16620b28a
Showing with 6 additions and 0 deletions.
  1. +6 −0 src/audio/SDL_audiocvt.c
@@ -1682,6 +1682,12 @@ SDL_BuildWindowedSinc(SDL_AudioCVT * cvt, SDL_AudioFormat format,
} \
}

/* !!! FIXME: this memory leaks. */
cvt->coeff = (Uint8 *) SDL_malloc((SDL_AUDIO_BITSIZE(format) / 8) * m);
if (cvt->coeff == NULL) {
return -1;
}

/* If we're using floating point, we only need to normalize */
if (SDL_AUDIO_ISFLOAT(format) && SDL_AUDIO_BITSIZE(format) == 32) {
float *fDest = (float *) cvt->coeff;

0 comments on commit 81c4db0

Please sign in to comment.