Fixed SDL_HapticRumblePlay() maybe working because of SDL_HapticUpdat…

…eEffect().
libsdl-org · Jul 27, 2013 · d02a1dd0cb172537c5d602d7f2b6729828741dfc · d02a1dd
1 parent 732787c
commit d02a1dd0cb172537c5d602d7f2b6729828741dfc
Unified Split

Showing with 2 additions and 4 deletions.

+2 −4 src/haptic/SDL_haptic.c
diff --git a/src/haptic/SDL_haptic.c b/src/haptic/SDL_haptic.c
@@ -781,7 +781,6 @@ SDL_HapticRumbleInit(SDL_Haptic * haptic)
 int
 SDL_HapticRumblePlay(SDL_Haptic * haptic, float strength, Uint32 length)
 {
-    int ret;
     SDL_HapticPeriodic *efx;
 
     if (!ValidHaptic(haptic)) {
@@ -804,9 +803,8 @@ SDL_HapticRumblePlay(SDL_Haptic * haptic, float strength, Uint32 length)
     efx = &haptic->rumble_effect.periodic;
     efx->magnitude = (Sint16)(32767.0f*strength);
     efx->length = length;
-    ret = SDL_HapticUpdateEffect(haptic, haptic->rumble_id, &haptic->rumble_effect);
-    if (ret) {
-        return ret;
+    if (SDL_HapticUpdateEffect(haptic, haptic->rumble_id, &haptic->rumble_effect) < 0) {
+        return -1;
     }
 
     return SDL_HapticRunEffect(haptic, haptic->rumble_id, 1);