Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

XGetWindowProperty() can report success but still give you a NULL poi…

…nter.

Thanks to Joseph Toppi for the fix!
  • Loading branch information
icculus committed Oct 22, 2011
1 parent 0d9b685 commit ff5f68ce61589dc8e3e8ea626f25a9dbb93a6c09
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/video/x11/SDL_x11window.c
@@ -593,14 +593,14 @@ X11_GetWindowTitle(_THIS, Window xwindow)
status = XGetWindowProperty(display, xwindow, data->_NET_WM_NAME,
0L, 8192L, False, data->UTF8_STRING, &real_type, &real_format,
&items_read, &items_left, &propdata);
if (status == Success) {
if (status == Success && propdata) {
title = SDL_strdup(SDL_static_cast(char*, propdata));
XFree(propdata);
} else {
status = XGetWindowProperty(display, xwindow, XA_WM_NAME,
0L, 8192L, False, XA_STRING, &real_type, &real_format,
&items_read, &items_left, &propdata);
if (status == Success) {
if (status == Success && propdata) {
title = SDL_iconv_string("UTF-8", "", SDL_static_cast(char*, propdata), items_read+1);
} else {
title = SDL_strdup("");

0 comments on commit ff5f68c

Please sign in to comment.