Skip to content
Permalink
Browse files

Fixed bug 2833 - Access Violation on SDL_PollEvent after init, delay …

…and quit of joystick subsystem

Jan Klass

Not sure if this is limited to the joystick subsystem,
but I created a minimal program for reproducibility,
which is attached.

The issue occurs with my gamepad Razer Onza (an xbox-style gamepad) plugged in.
On initialization, the gamepad is being recognized.
After quitting the subsystem, the poll will receive the joystick added event,
which it instantly handles itself, calling SDL_SYS_JoystickDetect again,
which this time calls IDirectInput8_EnumDevices with dinput = NULL (after it was released on quit).
This seems to lead to an access violation within said function, which I have no source for.
  • Loading branch information
slouken committed Oct 7, 2016
1 parent dac3892 commit 24df68ea33fd7b9ffaadf102a0c758c2b4c7528b
Showing with 3 additions and 0 deletions.
  1. +3 −0 src/joystick/windows/SDL_windowsjoystick.c
@@ -509,6 +509,9 @@ SDL_SYS_JoystickQuit(void)

SDL_DINPUT_JoystickQuit();
SDL_XINPUT_JoystickQuit();

s_bDeviceAdded = SDL_FALSE;
s_bDeviceRemoved = SDL_FALSE;
}

/* return the stable device guid for this device index */

0 comments on commit 24df68e

Please sign in to comment.