Skip to content
Permalink
Browse files

Fix incorrectly terminated MakeThreadHighPriority dbus message

Currently the message is double terminated, which results in SDL_DBus_CallMethodInternal()
incorrectly assuming that the other party is always returning true.

I'm not super familiar with dbus, so I'm not sure if this could also be the cause of this bug:
ValveSoftware/steam-for-linux#6901
  • Loading branch information
slouken committed Mar 30, 2020
1 parent 6e7465b commit 2e667a8be93525a73080547eda33f222c3dcad53
Showing with 1 addition and 2 deletions.
  1. +1 −2 src/core/linux/SDL_threadprio.c
@@ -68,8 +68,7 @@ rtkit_setpriority(pid_t thread, int nice_level)

if (!dbus || !SDL_DBus_CallMethodOnConnection(dbus->system_conn,
RTKIT_DBUS_NODE, RTKIT_DBUS_PATH, RTKIT_DBUS_INTERFACE, "MakeThreadHighPriority",
DBUS_TYPE_UINT64, &ui64, DBUS_TYPE_INT32, &si32, DBUS_TYPE_INVALID,
DBUS_TYPE_INVALID)) {
DBUS_TYPE_UINT64, &ui64, DBUS_TYPE_INT32, &si32, DBUS_TYPE_INVALID)) {
return SDL_FALSE;
}
return SDL_TRUE;

0 comments on commit 2e667a8

Please sign in to comment.