From 5191b20541fce0e3b3071124ced69c31fcaeb783 Mon Sep 17 00:00:00 2001 From: "Ryan C. Gordon" Date: Wed, 23 Aug 2023 16:11:08 -0400 Subject: [PATCH] emscriptenaudio: Don't bother undefining things about to be unreachable. Since the top-level table is getting undefined, all the things in it will be unreachable and eligible for garbage collection without explicitly nulling them out. --- src/audio/emscripten/SDL_emscriptenaudio.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/audio/emscripten/SDL_emscriptenaudio.c b/src/audio/emscripten/SDL_emscriptenaudio.c index 1fbb0274ef56f..dae5d2f7dc3ff 100644 --- a/src/audio/emscripten/SDL_emscriptenaudio.c +++ b/src/audio/emscripten/SDL_emscriptenaudio.c @@ -104,32 +104,22 @@ static void EMSCRIPTENAUDIO_CloseDevice(SDL_AudioDevice *device) for (var i = 0; i < tracks.length; i++) { SDL3.capture.stream.removeTrack(tracks[i]); } - SDL3.capture.stream = undefined; } if (SDL3.capture.scriptProcessorNode !== undefined) { SDL3.capture.scriptProcessorNode.onaudioprocess = function(audioProcessingEvent) {}; SDL3.capture.scriptProcessorNode.disconnect(); - SDL3.capture.scriptProcessorNode = undefined; } if (SDL3.capture.mediaStreamNode !== undefined) { SDL3.capture.mediaStreamNode.disconnect(); - SDL3.capture.mediaStreamNode = undefined; - } - if (SDL3.capture.silenceBuffer !== undefined) { - SDL3.capture.silenceBuffer = undefined } SDL3.capture = undefined; } else { if (SDL3.audio.scriptProcessorNode != undefined) { SDL3.audio.scriptProcessorNode.disconnect(); - SDL3.audio.scriptProcessorNode = undefined; } if (SDL3.audio.silenceTimer !== undefined) { clearInterval(SDL3.audio.silenceTimer); } - if (SDL3.audio.silenceBuffer !== undefined) { - SDL3.audio.silenceBuffer = undefined - } SDL3.audio = undefined; } if ((SDL3.audioContext !== undefined) && (SDL3.audio === undefined) && (SDL3.capture === undefined)) {