Skip to content
Permalink
Browse files

Fixed bug 2681 - dereference a NULL pointer dst_fmt in SDL_CreateText…

…ureFromSurface function

Nitz

In SDL_CreateTextureFromSurface:

SDL_PixelFormat *dst_fmt;
/* Set up a destination surface for the texture update */
         dst_fmt = SDL_AllocFormat(format);
            temp = SDL_ConvertSurface(surface, dst_fmt, 0);

Here is need of NULL check for dst_fmt because there are chances of NULL return from SDL_AllocFormat(format);
  • Loading branch information
slouken committed Aug 17, 2014
1 parent 984d0fc commit 529ed53b16a8e35c81fe3ae3bbf4870067040a22
Showing with 4 additions and 0 deletions.
  1. +4 −0 src/render/SDL_render.c
@@ -540,6 +540,10 @@ SDL_CreateTextureFromSurface(SDL_Renderer * renderer, SDL_Surface * surface)

/* Set up a destination surface for the texture update */
dst_fmt = SDL_AllocFormat(format);
if (!dst_fmt) {
SDL_DestroyTexture(texture);
return NULL;
}
temp = SDL_ConvertSurface(surface, dst_fmt, 0);
SDL_FreeFormat(dst_fmt);
if (temp) {

0 comments on commit 529ed53

Please sign in to comment.