Skip to content
Permalink
Browse files

Fixed bug 3751 - DirectFB linux_input disabled by default

Clayton Craft

linux_input module is disabled by default, despite the comments in source code that it is otherwise:

src/video/directfb/SDL_DirectFB_video.c:
    devdata->use_linux_input = readBoolEnv(DFBENV_USE_LINUX_INPUT, 0);       /* default: on */

src/video/directfb/SDL_DirectFB_video.h:
    #define DFBENV_USE_LINUX_INPUT      "SDL_DIRECTFB_LINUX_INPUT"      /* Default: on  */

When using the directfb driver, the linux_input module is suppressed unless the SDL app is started with "SDL_DIRECTFB_LINUX_INPUT=1" set in the environment. I recall seeing at one point that the directfb folks recommended using linux_input over the other input drivers, but I am having trouble locating this recommendation. In any case, I believe that this should really be defaulted to 'on' since it's vastly superior to the other dfb input drivers!
  • Loading branch information
slouken committed Aug 14, 2017
1 parent ddeaa60 commit 6ef1a25d181b9fac58de6de5b172ba173473fef1
Showing with 1 addition and 2 deletions.
  1. +1 −2 src/video/directfb/SDL_DirectFB_video.c
@@ -228,8 +228,7 @@ DirectFB_VideoInit(_THIS)
DirectFBSetOption("disable-module", "x11input");
}

/* FIXME: Reenable as default once multi kbd/mouse interface is sorted out */
devdata->use_linux_input = readBoolEnv(DFBENV_USE_LINUX_INPUT, 0); /* default: on */
devdata->use_linux_input = readBoolEnv(DFBENV_USE_LINUX_INPUT, 1); /* default: on */

if (!devdata->use_linux_input)
{

0 comments on commit 6ef1a25

Please sign in to comment.