Skip to content
Permalink
Browse files

Fixed bug 5005 - warnings in kmsdrm

Malte Kie?ling

At the moment i get following warnings from kmsdrm:

 * in SDL_kmsdrmvideo.c KMSDRM_DestroySurfaces is return type int, but thats never returned or checked against
 * in SDL_kmsdrmvideo.c KMSDRM_DestroySurfaces the variable viddata is not used
 * in SDL_kmsdrmopengles.c KMSDRM_GLES_LoadLibrary a cast to NativeDisplayType is missing

I attached a patch for them :)
  • Loading branch information
slouken committed Feb 27, 2020
1 parent 7f26ff2 commit 9013c9169c089d7b2a35b7c6050128980b6e1e77
Showing with 3 additions and 3 deletions.
  1. +2 −1 src/video/kmsdrm/SDL_kmsdrmopengles.c
  2. +1 −2 src/video/kmsdrm/SDL_kmsdrmvideo.c
@@ -37,7 +37,8 @@

int
KMSDRM_GLES_LoadLibrary(_THIS, const char *path) {
return SDL_EGL_LoadLibrary(_this, path, ((SDL_VideoData *)_this->driverdata)->gbm, EGL_PLATFORM_GBM_MESA);
NativeDisplayType display = (NativeDisplayType)((SDL_VideoData *)_this->driverdata)->gbm;
return SDL_EGL_LoadLibrary(_this, path, display, EGL_PLATFORM_GBM_MESA);
}

SDL_EGL_CreateContext_impl(KMSDRM)
@@ -349,10 +349,9 @@ KMSDRM_WaitPageFlip(_THIS, SDL_WindowData *windata, int timeout) {
/* SDL Video and Display initialization/handling functions */
/* _this is a SDL_VideoDevice * */
/*****************************************************************************/
static int
static void
KMSDRM_DestroySurfaces(_THIS, SDL_Window * window)
{
SDL_VideoData *viddata = ((SDL_VideoData *)_this->driverdata);
SDL_WindowData *windata = (SDL_WindowData *)window->driverdata;

KMSDRM_WaitPageFlip(_this, windata, -1);

0 comments on commit 9013c91

Please sign in to comment.