Skip to content
Permalink
Browse files

audio: SDL_ResampleCVT() should use memmove instead of memcpy.

This copy can overlap.

Fixes Bugzilla #3849.
  • Loading branch information
icculus committed Oct 11, 2017
1 parent 42fff7c commit 903ff6414eecc42b2b36c35d67e9b78fe7cb9d7a
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/audio/SDL_audiocvt.c
@@ -732,7 +732,7 @@ SDL_ResampleCVT(SDL_AudioCVT *cvt, const int chans, const SDL_AudioFormat format

SDL_free(padding);

SDL_memcpy(cvt->buf, dst, cvt->len_cvt); /* !!! FIXME: remove this if we can get the resampler to work in-place again. */
SDL_memmove(cvt->buf, dst, cvt->len_cvt); /* !!! FIXME: remove this if we can get the resampler to work in-place again. */

if (cvt->filters[++cvt->filter_index]) {
cvt->filters[cvt->filter_index](cvt, format);

0 comments on commit 903ff64

Please sign in to comment.