Skip to content
Permalink
Browse files
src/video/kmsdrm/SDL_kmsdrmvideo.c: fix build
Build is broken without EGL since version 2.0.12 and
https://hg.libsdl.org/SDL/rev/72cc4740dec2:

/home/giuliobenetti/autobuild/run/instance-1/output-1/build/sdl2-2.0.12/src/video/kmsdrm/SDL_kmsdrmvideo.c: In function 'KMSDRM_CreateSurfaces':
/home/giuliobenetti/autobuild/run/instance-1/output-1/build/sdl2-2.0.12/src/video/kmsdrm/SDL_kmsdrmvideo.c:394:5: error: unknown type name 'EGLContext'
     EGLContext egl_context;
     ^

Fixes:
 - http://autobuild.buildroot.org/results/fafd20a01591032662f9ca025fcea3478239cf3c

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
  • Loading branch information
ffontaine committed Mar 25, 2020
1 parent a4b0204 commit 9354aea19834ada7ffb90d379600a242a7aa820f

File 1 of 1 in 9354aea

@@ -391,7 +391,9 @@ KMSDRM_CreateSurfaces(_THIS, SDL_Window * window)
Uint32 height = dispdata->mode.vdisplay;
Uint32 surface_fmt = GBM_FORMAT_XRGB8888;
Uint32 surface_flags = GBM_BO_USE_SCANOUT | GBM_BO_USE_RENDERING;
#if SDL_VIDEO_OPENGL_EGL
EGLContext egl_context;
#endif

if (!KMSDRM_gbm_device_is_format_supported(viddata->gbm, surface_fmt, surface_flags)) {
SDL_LogWarn(SDL_LOG_CATEGORY_VIDEO, "GBM surface format not supported. Trying anyway.");

4 comments on commit 9354aea

@pcercuei

This comment has been minimized.

Copy link
Contributor

@pcercuei pcercuei replied Mar 17, 2021

This fix magically disappeared in git master... ?!?

@ffontaine

This comment has been minimized.

Copy link
Contributor Author

@ffontaine ffontaine replied Mar 18, 2021

SDL_VIDEO_OPENGL_EGL has been dropped by 2fc987c which disables kmsdrm without EGL

@pcercuei

This comment has been minimized.

Copy link
Contributor

@pcercuei pcercuei replied Mar 18, 2021

That's a step backwards, IMHO. KMS/DRM should be usable without a GPU...

@ffontaine

This comment has been minimized.

Copy link
Contributor Author

@ffontaine ffontaine replied Mar 18, 2021

Then, I would suggest to open an issue, I just tried to answer your question and I'm not really involved in SDL.

Please sign in to comment.