Skip to content
Permalink
Browse files

Fixed bug 2219 - BMP loader do not handle big BITMAPINFOHEADER structure

Patrice Mandin

I encountered a problem trying to load a 8-bit paletted BMP file using SDL. This file was generated using GIMP 2.8. It has a big BITMAPINFOHEADER (0x6c bytes for biSize field), and thus the palette is incorrectly setup.
  • Loading branch information
slouken committed Nov 8, 2013
1 parent 48e44f7 commit 95c67ed9a77a684b6ee7dc2197f412d48764408f
Showing with 6 additions and 0 deletions.
  1. +6 −0 src/video/SDL_bmp.c
@@ -150,6 +150,8 @@ SDL_LoadBMP_RW(SDL_RWops * src, int freesrc)
biBitCount = SDL_ReadLE16(src);
biCompression = BI_RGB;
} else {
const int headerSize = 40;

biWidth = SDL_ReadLE32(src);
biHeight = SDL_ReadLE32(src);
/* biPlanes = */ SDL_ReadLE16(src);
@@ -160,6 +162,10 @@ SDL_LoadBMP_RW(SDL_RWops * src, int freesrc)
/* biYPelsPerMeter = */ SDL_ReadLE32(src);
biClrUsed = SDL_ReadLE32(src);
/* biClrImportant = */ SDL_ReadLE32(src);

if (biSize > headerSize) {
SDL_RWseek(src, (biSize - headerSize), RW_SEEK_CUR);
}
}
if (biHeight < 0) {
topDown = SDL_TRUE;

0 comments on commit 95c67ed

Please sign in to comment.